docs(php-beginner): show the real router:list output in module 3 - #51
Open
miaulalala wants to merge 1 commit into
Open
docs(php-beginner): show the real router:list output in module 3#51miaulalala wants to merge 1 commit into
miaulalala wants to merge 1 commit into
Conversation
Follow-up to #48. The command was fixed there, but the expected-output block underneath still showed borderless columns, so readers hit a second mismatch right after the first one was resolved: router:list renders a bordered Symfony table with route/request/path headers. Also drop the '| grep pinboard' in favour of the app-ID argument that router:list accepts. Filtering the full route list strips the headers and makes the column widths depend on every other app's routes, so the output could never be quoted reliably. Signed-off-by: Anna Larch <anna@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #48 (thanks @yard-mschwartz).
#48 fixed the command itself — there is no
occ routes, it'srouter:list(core/Command/Router/ListRoutes.php:34). But the expected-output block underneath it was still wrong, so a reader who applies #48 hits a second mismatch immediately:router:listrenders throughwriteTableInOutputFormat, i.e. a bordered Symfony table withroute/request/pathheaders, not the borderless columns the module showed.Also replaces
| grep pinboardwith the app-ID argumentrouter:listaccepts. Two reasons:grepstrips the table headers, andAdded a one-line note that routes sort alphabetically, since
get_pinsappearing beforeindexotherwise looks like something is wrong.The table in this PR is derived from the Symfony
Tabledefault style and the sort inListRoutes::execute(), not copied from an actual run — I had no instance to run it against. The content is right; the exact border widths should be confirmed by pasting a real./scripts/occ.sh nextcloud -- router:list pinboardbefore merging, otherwise we risk replacing one invented output block with another.🤖 AI (if applicable)